Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aht20): raw humidity/temperature data conversion (AEGHB-505) #323

Closed
wants to merge 1 commit into from

Conversation

kylecmarshall
Copy link

Concerning the conversion of raw_data to humidity/temperature:

humidity = raw_data * 100 / 1048576 gives a max humidity of 99.99990

To get a max humidity of 100:
humidity = raw_data * 100 / 1048575

Similar arguments can be made for the temperature.

raw_data * 100 / 1048576 gives a max humidity of 99.99990

To get a max humidity of 100:
humidity = raw_data * 100 / 1048575

Similar arguments for temperature
@CLAassistant
Copy link

CLAassistant commented Dec 30, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Dec 30, 2023

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Fixed aht20.c raw data conversion":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello kylecmarshall, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against caea51d

@github-actions github-actions bot changed the title Fixed aht20.c raw humidity/temperature data conversion Fixed aht20.c raw humidity/temperature data conversion (AEGHB-505) Dec 30, 2023
@kylecmarshall kylecmarshall changed the title Fixed aht20.c raw humidity/temperature data conversion (AEGHB-505) fix(aht20): raw humidity/temperature data conversion (AEGHB-505) Dec 30, 2023
@leeebo
Copy link
Collaborator

leeebo commented Dec 31, 2023

@kylecmarshall Thanks, your modifications make sense, we will accept soon

@kylecmarshall
Copy link
Author

@leeebo I reviewed the datasheet for the AHT20. It very clearly shows that you are supposed to divide by 2^20. I looked at Adafruit's implementation: they also divide by 2^20. So please disregard this change.

@leeebo
Copy link
Collaborator

leeebo commented Jan 4, 2024

@kylecmarshall OK, thanks for your feedback, let's just close this PR

@leeebo leeebo closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants