Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ethernet_init): Adds default pin for esp32P4 #50

Closed

Conversation

euripedesrocha
Copy link
Collaborator

Description

Adds default pin for esp32-P4 to ethernet init component.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@kostaond
Copy link
Collaborator

kostaond commented Feb 4, 2025

Duplicate to #33

@kostaond
Copy link
Collaborator

kostaond commented Feb 4, 2025

PR #33 got a little bit stuck because build for ESP32P4 is missing. We really need to take care of this repo's workflow...

@kostaond kostaond closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants