Add driver for lan867x (IDFGH-11626) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostaond
requested review from
espressif-abhikroy,
kostaond,
david-cermak and
suda-morris
This was referenced Dec 6, 2023
kostaond
reviewed
Dec 6, 2023
|
Please add building of example to workflow. |
github-actions
bot
changed the title
bogdankolendovskyy
force-pushed
the
master
branch
from
c8fcb42 to
218630b
Compare
espressif-bot
added
Status: In Progress
adeepn
added a commit
to adeepn/esphome
that referenced
this pull request
Dec 11, 2023
…for IDF>=5 Based on work @bigdankolendovskyy espressif/esp-eth-drivers#19
13 tasks
adeepn
added a commit
to adeepn/esphome
that referenced
this pull request
Dec 12, 2023
…for IDF>=5 Based on work @bigdankolendovskyy espressif/esp-eth-drivers#19
There was a problem hiding this comment.
Nice work @bogdankolendovskyy!
Left a few comments, but it looks good.
I missed a README file in the example.
kostaond
reviewed
Dec 14, 2023
lan867x/examples/lan867x_tcp_sockets/client/main/CMakeLists.txt
Outdated
Show resolved
Hide resolved
lan867x/examples/lan867x_tcp_sockets/server/main/CMakeLists.txt
Outdated
Show resolved
Hide resolved
bogdankolendovskyy
force-pushed
the
master
branch
2 times, most recently
from
3c30505 to
2f2f6a0
Compare
kostaond
reviewed
Feb 9, 2024
kostaond
reviewed
Feb 9, 2024
kostaond
reviewed
Feb 9, 2024
kostaond
reviewed
Feb 9, 2024
kostaond
reviewed
Feb 9, 2024
kostaond
reviewed
Feb 9, 2024
kostaond
reviewed
Feb 9, 2024
kostaond
reviewed
Feb 9, 2024
bogdankolendovskyy
force-pushed
the
master
branch
5 times, most recently
from
0d228c6 to
2559390
Compare
kostaond
reviewed
Feb 14, 2024
bogdankolendovskyy
force-pushed
the
master
branch
2 times, most recently
from
e446e91 to
6329c78
Compare
kostaond
reviewed
Feb 27, 2024
kostaond
reviewed
Feb 27, 2024
bogdankolendovskyy
force-pushed
the
master
branch
from
6329c78 to
73eabc9
Compare
bogdankolendovskyy
force-pushed
the
master
branch
3 times, most recently
from
a8106c3 to
bf33fe0
Compare
Initial version of a driver for Microchip LAN867x. Implements all main functions for lan867x driver, as well as example utilizing esp-netif and lwIP.
bogdankolendovskyy
force-pushed
the
master
branch
from
bf33fe0 to
13d00d8
Compare
espressif-bot
added
Status: Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version of a driver for Microchip LAN867x.
Implements all main functions for lan867x driver, as well as example utilizing esp-netif and lwIP.
PLCA configuration is not yet fully tested.