This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
feature (gps-rtc): GPS RTC via UART added. Dependencies: TinyGPS #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Otto,
first of all thanks for outstanding works, esphome is very impressive.
Please, have a look at my request.
It adds ability to use typical gps module as (and only) RTC for esphome,
unfortunally only for ESP8266, I have no ESP32 atm, but imho code should work for it too.
It also relies on tinygps as parsing NMEA format lib for simplicity. Idk if it will suit you.
Please, let me know if code is properely formatted for your requirements, I'm not C++ guy at all.
Also I have a question related to work with TZs: even timezone is given in config, or fron local PC
now() returns UTC as well as utcnow(). I tried to understand why so, but finally got no clue on it.
Pull request in esphome with python changes (if applicable): esphome/esphome#509