Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Rework CI #132

Merged
merged 11 commits into from
Dec 17, 2023
Merged

Rework CI #132

merged 11 commits into from
Dec 17, 2023

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Dec 15, 2023

  • Use a bash script
    • Can be used locally by modifying the template_path and executed from outside your local esp-template repo (no cargo command works inside that folder because of the syntax errors in all the files)
  • Only cover the simplest and more complex cases of options
  • act is not working out of the box:
    • rust_ci.yml needs to be moved from the .github/workflows/ folder as it fails to parse it due to the weird syntax, again.
      • Did some further testing and solved this by moving the rust_ci.yml to a different folder, .github and the on the post-script.rhai move it to the .github/workflows/ if the user accepted the CI prompt. Not very clean, but it allows using act, happy to improve or remove this workaround.
    • After moving the rust_ci.yml, it works, just make sure you specify the GH TOKEN, required for Xtensa toolchain action: act -s GITHUB_TOKEN="$(gh auth token)" -j verify

Thanks @jessebraham for the ideas to improve the workflow! Any feedback on how to improve it further is more than welcomed!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea of moving functionality to a locally runnable script 👍

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for wrapping this up for me, much much better now!

@jessebraham jessebraham merged commit ab1eaf4 into esp-rs:main Dec 17, 2023
7 checks passed
@SergioGasquez SergioGasquez deleted the feat/ci branch December 18, 2023 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants