Fix build of libesmftrace_preload.dylib on Darwin-openmpi #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had removed `$(ESMF_F90LINKPATHS) $(ESMF_F90LINKLIBS)` from `ESMF_SL_LIBLIBS` because it was redundant. But since then, Gerhard added some code that set `ESMF_F90LINKPATHS += -L$(dir $(ESMF_LIBSTDCXX))` and `ESMF_F90LINKLIBS += -lm -lc++`, so now they are no longer redundant.
Previously, C++ flags / libs were used regardless of whether a C++ or Fortran linker was being used. This commit changes this behavior to use F90 flags when using an F90 linker.
theurich
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
This looks really nice and clean. Thank you @billsacks for cleaning up this mess!
billsacks
added a commit
that referenced
this pull request
Feb 7, 2024
…h/8.6.1 This is equivalent to pull request #221 but for the patch/8.6.1 branch Fix build of libesmftrace_preload.dylib on Darwin-openmpi With Darwin-openmpi, we use a Fortran linker for libesmftrace_preload.dylib. But the link command was using flags appropriate for a C++ linker rather than a Fortran linker. This PR changes the link flags to be appropriate for a Fortran linker in this case. In the context of the develop branch: - I have tested this on my Mac (green, with gfortranclang+openmpi) and confirmed that this resolves the build issues I was running into. - I have also tested this on catania and derecho to ensure that this doesn't break the build / test on other systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Darwin-openmpi, we use a Fortran linker for libesmftrace_preload.dylib. But the link command was using flags appropriate for a C++ linker rather than a Fortran linker. This PR changes the link flags to be appropriate for a Fortran linker in this case.
I have tested this on my Mac (green, with gfortranclang+openmpi) and confirmed that this resolves the build issues I was running into.
I have also tested this on catania and derecho to ensure that this doesn't break the build / test on other systems.
@theurich I'd welcome a quick look.