Use v4 of the upload-artifact action

The v3 upload-artifact action is deprecated and will be removed in the
future. This PR updates the action to use v4.

Note possibly breaking changes given in
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md.
I haven't reviewed these carefully, but at a glance I don't see use of
these patterns.

.github/workflows/api-change.yml

@@ -41,7 +41,7 @@ jobs:
         docker rm ${CID}
             
     - name: Upload artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: api-change
         path: ${{ github.workspace }}/artifacts

.github/workflows/build-esmf-docs.yml

@@ -37,7 +37,7 @@ jobs:
         docker rm ${CID}        
             
     - name: Upload artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: esmf-docs
         path: ${{ github.workspace }}/artifacts

.github/workflows/build-esmpy-docs.yml

@@ -37,7 +37,7 @@ jobs:
         docker rm ${CID}
             
     - name: Upload artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: esmpy-docs
         path: ${{ github.workspace }}/artifacts

.github/workflows/test-build-spack.yml

@@ -143,7 +143,7 @@ jobs:
 
    # push test results to artifacts
     - name: Upload Artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: Artifacts for ${{ matrix.compiler }} ${{ matrix.esmf }}
         path: ${{ github.workspace }}/nuopc-app-prototypes/Artifacts

.github/workflows/test-coverage.yml

@@ -32,7 +32,7 @@ jobs:
         docker rm ${CID}
 
     - name: Upload artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: test-coverage
         path: ${{ github.workspace }}/artifacts