Bump dependencies and Erlang versions #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
force-pushed
the
upgrades
branch
2 times, most recently
from
c15424e to
94fd04d
Compare
src/helpers/amoc_xmpp_handlers.erl
Outdated
| @@ -23,9 +23,12 @@ | |||
| %% Types | |||
| -type handler_spec() :: {escalus_connection:stanza_pred(), action()}. | |||
|
|
|||
| %% TODO: export this type from escalus | |||
There was a problem hiding this comment.
was escalus_connection:metadata() type unexported?
There was a problem hiding this comment.
Yeap, it is unexported. I didn't want to block this one by yet another PR in escalus to export it and so on, but that's a pending task there 🥲
DenysGonchar
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.