Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 2025.1 #62

Merged
merged 41 commits into from
Jan 20, 2025
Merged

New version 2025.1 #62

merged 41 commits into from
Jan 20, 2025

Conversation

pantaray
Copy link
Member

@pantaray pantaray commented Jan 20, 2025

Summary

  • preps for new release

Author Guidelines

  • Is the code running locally and on HPC infrastructure?
  • Is the code running on all supported platforms (macOS, Linux and Windows)?

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Are proposed changes tracked in CHANGELOG.md?

- reset CHANGELOG

On branch dev
Changes to be committed:
	modified:   CHANGELOG.md
- rolled back (dysfunctional) changes in Windows CI setup
  (the package `py` was not installed in the Win environment,
  making conda use a Py37 system version of tox...)
- removed linux_ppc64le job: running ACME w/o SLURM on a POWER
  machine via `LocalCluster` is not neither encouraged nor
  particularly useful.

On branch dev
Changes to be committed:
	modified:   .gitlab-ci.yml
- added notes on how to work with ACME's conda-forge feedstock

On branch dev
Changes to be committed:
	modified:   RELEASE.md
- define formatting of logging handlers upon creation of the handlers
- use ASCII-only formatting for log-files

On branch dev
Changes to be committed:
	modified:   acme/logger.py
- modified `SLURMCluster` invocation so that resource specs are
  correctly propagated to SLURM workers (closes #60)
- fixed type declaration in `slurm_cluster_setup`: `mem_per_worker` can
  be `None`
- adapted corresponding test

On branch dev
Changes to be committed:
	modified:   acme/dask_helpers.py
	modified:   acme/tests/test_dask.py
- updated dask and msgpack version requirements (closes #59)
- dropped Python 3.7 support

On branch dev
Changes to be committed:
	modified:   setup.cfg
- summarized recent changes

On branch dev
Changes to be committed:
	modified:   CHANGELOG.md
- when falling back to partition max/default for allocating a job's
  memory requirements, allow for a 500MB cushion to not trigger QoS
  violations
- modified test to reflect this change

On branch dev
Changes to be committed:
	modified:   acme/dask_helpers.py
	modified:   acme/tests/test_dask.py
	modified:   acme/tests/test_internals.py
	modified:   acme/tests/test_pmap.py
- to hopefully not trigger `distutils` errors in the GitHub runners

On branch dev
Changes to be committed:
	modified:   acme/backend.py
- removed (where sensible) old-style .format() with new f-strings

On branch dev
Changes to be committed:
	modified:   acme/backend.py
	modified:   acme/dask_helpers.py
	modified:   acme/logger.py
	modified:   acme/shared.py
	modified:   acme/tests/test_dask.py
	modified:   acme/tests/test_pmap.py
	modified:   setup.py
- as announced in the previous release

On branch dev
Changes to be committed:
	modified:   CHANGELOG.md
	modified:   acme/dask_helpers.py
- cf previous commits

On branch dev
Changes to be committed:
	modified:   acme/tests/test_dask.py
- first prototype code for handling `np.inf`, i.e., a dimension of
  unspecified size, in `result_shape`
- added first round of tests
- TODO: provide GitHub example (+ add corresponding test)

On branch dev
Changes to be committed:
	modified:   acme/backend.py
	modified:   acme/tests/local_acme.py
	modified:   acme/tests/test_pmap.py
- in test_pmap.py

On branch dev
Changes to be committed:
	modified:   acme/tests/test_pmap.py
- put together Walkthrough section + started Advanced section

On branch dev
Changes to be committed:
	modified:   README.md
	modified:   doc/source/advanced_usage.rst
	modified:   doc/source/userguide.rst
- removed now deprecated `start_client` keyword
- do not check for error message only popping up in `esi_cluster_setup`

On branch dev
Changes to be committed:
	modified:   acme/dask_helpers.py
	modified:   acme/tests/test_dask.py
- do not track .dir-locals.el

On branch dev
Changes to be committed:
	modified:   .gitignore
- do not check for explicit string in error message as SIGINT
  is handled differently in modern Dask and Python 3.13

On branch dev
Changes to be committed:
	modified:   acme/tests/test_pmap.py
- variable is called `tmpQ` not `tmpq`

On branch dev
Changes to be committed:
	modified:   acme/tests/test_dask.py
- ensure only a single tasks executes test pipeline

On branch dev
Changes to be committed:
	modified:   acme/tests/run_tests.sh
- added support for Python 3.13 and Numpy 2.0+
- tested w/current version of Dask

On branch dev
Changes to be committed:
	modified:   setup.cfg
- added short moving average example

On branch dev
Changes to be committed:
	modified:   doc/source/advanced_usage.rst
- the used bootstrap theme seems abandoned; new versions of Sphinx are
  not supported anymore
- updated dependencies and Sphinx config

On branch dev
Changes to be committed:
	modified:   doc/source/conf.py
	modified:   setup.cfg
- removed local "Quick Links" sections at top of page
- include "Home" link (pointing to index.html) in navbar

On branch dev
Changes to be committed:
	modified:   doc/source/advanced_usage.rst
	modified:   doc/source/conf.py
	modified:   doc/source/contributing.rst
	modified:   doc/source/troubleshooting_faq.rst
	modified:   doc/source/userguide.rst
- included link to RELEASE.md in Contributing guide

On branch dev
Changes to be committed:
	modified:   source/contributing.rst
- preps for next release

On branch dev
Changes to be committed:
	modified:   CHANGELOG.md
- restrict allowed h5py versions to 3.x

On branch dev
Changes to be committed:
	modified:   setup.cfg
- fixed broken package mapping for constructing acme.yml in setup.py
- fixed borked f-strings that use dict values in `{}` (works fine in Py3.12+
  but not Py3.11)

On branch dev
Changes to be committed:
	modified:   acme/dask_helpers.py
	modified:   setup.py
- updated CITATION.cff and conda environment file by invoking
  (now fixed) setup.py

On branch dev
Changes to be committed:
	modified:   CITATION.cff
	modified:   acme.yml
- updated dependencies
- removed conda defaults channel
- removed Py3.10, only test Py3.11+

On branch dev
Changes to be committed:
	modified:   tox.ini
- specify channels as list in setup.py to avoid YAML parsing
  errors

On branch dev
Changes to be committed:
	modified:   CITATION.cff
	modified:   acme.yml
	modified:   setup.py
- use the miniforge action from conda-incubator for running the
  GitHub action

On branch dev
Changes to be committed:
	modified:   .github/workflows/tests_workflow.yml
- remove `{envdir}` after test run to not clutter runners

On branch dev
Changes to be committed:
	modified:   acme.yml
	modified:   tox.ini
- ACME has been rarely used on Windows clients. Ensuring Windows
  compatibility is quite some work with potentially very little
  benefit. ACME should continue to run on Windows machines but
  is untested from now on. CHANGELOG has been modified accordingly.
- removed Windows testing pipeline from GitLab CI setup
- removed colorama from dependencies (only required on Windows)
- updated documentation (specifically, contributing guideline)
- updated GitHub workflow (to use bash and activate the created
  acme environment)

On branch dev
Changes to be committed:
	modified:   .github/pull_request_template.md
	modified:   .github/workflows/tests_workflow.yml
	modified:   .gitlab-ci.yml
	modified:   CHANGELOG.md
	modified:   acme.yml
	modified:   acme/dask_helpers.py
	modified:   doc/source/contributing.rst
	modified:   setup.cfg
- do not attempt to activate acme environment in GitHub action
  workflow
- updated srun options to avoid accidentally executing tests
  concurrently

On branch dev
Changes to be committed:
	modified:   .github/workflows/tests_workflow.yml
	modified:   .gitlab-ci.yml
- do not atttempt to run Py311, Py312, Py313 pipelines in parallel
  on macOS (times out on ESI Mac Mini)
- check for correct error message when invoking `slurm_cluster_setup`
  on non-SLURM node
- clean up `LocalCluster` and wait 2 seconds when running GitHub
  examples in GitHub action
- removed (hacky) no_slurm.sh workaround for GitLab runner

On branch dev
Changes to be committed:
	modified:   .gitlab-ci.yml
	deleted:    acme/tests/no_slurm.sh
	deleted:    acme/tests/run_tests.cmd
	modified:   acme/tests/test_dask.py
	modified:   acme/tests/test_pmap.py
	modified:   tox.ini
- only run pytest on configured acme environment, don't run the
  full tox suite

On branch dev
Changes to be committed:
	modified:   .gitlab-ci.yml
- updated CHANGELOG

On branch dev
Changes to be committed:
	modified:   CHANGELOG.md
- included current year

On branch dev
Changes to be committed:
	modified:   .coveragerc
	modified:   .github/ISSUE_TEMPLATE/bug_report.md
	modified:   .github/ISSUE_TEMPLATE/new_feature.md
	modified:   .github/ISSUE_TEMPLATE/questions.md
	modified:   .github/pull_request_template.md
	modified:   .github/workflows/tests_workflow.yml
	modified:   .gitignore
	modified:   .gitlab-ci.yml
	modified:   .readthedocs.yaml
	modified:   LICENSE
	modified:   LICENSES/BSD-3-Clause.txt
	modified:   MANIFEST.in
	modified:   README.md
	modified:   RELEASE.md
	modified:   SECURITY.md
	modified:   acme/__init__.py
	modified:   acme/backend.py
	modified:   acme/dask_helpers.py
	modified:   acme/frontend.py
	modified:   acme/logger.py
	modified:   acme/shared.py
	modified:   acme/spy_interface.py
	modified:   acme/tests/README.md
	modified:   acme/tests/conftest.py
	modified:   acme/tests/local_acme.py
	modified:   acme/tests/run_tests.sh
	modified:   acme/tests/test_dask.py
	modified:   acme/tests/test_internals.py
	modified:   acme/tests/test_pmap.py
	modified:   codecov.yml
	modified:   doc/Makefile
	modified:   doc/make.bat
	modified:   doc/source/_static/acme_demo.gif.license
	modified:   doc/source/_static/acme_icon.ico.license
	modified:   doc/source/_static/acme_icon.png.license
	modified:   doc/source/_static/acme_icon.svg.license
	modified:   doc/source/_static/acme_logo.png.license
	modified:   doc/source/_static/acme_logo.svg.license
	modified:   doc/source/_static/classifier_tutorial.png.license
	modified:   doc/source/_static/dashboard.gif.license
	modified:   doc/source/_static/esi-style.css
	modified:   doc/source/_static/subject0.png.license
	modified:   doc/source/advanced_usage.rst
	modified:   doc/source/api.rst
	modified:   doc/source/best_practices.rst
	modified:   doc/source/classifier_tutorial.rst
	modified:   doc/source/conf.py
	modified:   doc/source/connectome_tutorial.rst
	modified:   doc/source/contributing.rst
	modified:   doc/source/deeplearning_tutorial.rst
	modified:   doc/source/index.rst
	modified:   doc/source/quickstart.rst
	modified:   doc/source/troubleshooting_faq.rst
	modified:   doc/source/tutorials.rst
	modified:   doc/source/userguide.rst
	modified:   pyproject.toml
	modified:   setup.cfg
	modified:   setup.py
	modified:   tox.ini
- use same Python version as current acme environment is using

On branch dev
Changes to be committed:
	modified:   .gitlab-ci.yml
- prepare new release

On branch dev
Changes to be committed:
	modified:   CITATION.cff
	modified:   acme.yml
	modified:   setup.py
@pantaray pantaray self-assigned this Jan 20, 2025
@pantaray pantaray merged commit aa9af39 into main Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant