Switch to ImageIO #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not develop this package, I just started to maintain it out of self defense since the original author moved on. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this package 🙂
When setting up my new Mac, I ran into JuliaIO/ImageMagick.jl#209. Based on how long this issue has been open, I assume it won't be fixed soon - but I would like to keep using SixelTerm! So in this PR I propose to replace ImageMagick.jl with ImageIO.jl and thereby remove the dependency on ImageMagick. Instead png, jpeg, sixel, ... support would be provided by ImageIO and the underlying libraries such as libsixel. With these changes I could use SixelTerm successfully on my Mac.
As a side effect (?) of this PR I noticed that the order of loading Plots and SixelTerm does not matter anymore - plotting in the terminal (iTerm2) worked in both cases.