Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StreamFailureHandler #95

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

snovak7
Copy link
Contributor

@snovak7 snovak7 commented Jun 29, 2024

in part fixes #83

Enables setting StreamFailureHandler, the RabbitMqStreamDeliveryFailureHandler currently works same as NoOpStreamDeliveryFailureHandler, but logs when failures occur, also added that failure fault the subscription which might reset the pulling agent - have to confirm with Orleans team

New StreamFailureHandler is opt-in, and default is is still NoOpStreamDeliveryFailureHandler

@snovak7 snovak7 linked an issue Jun 29, 2024 that may be closed by this pull request
@snovak7 snovak7 added enhancement New feature or request minor Minor changes labels Jun 29, 2024
@snovak7 snovak7 added this to the v0.3.0 milestone Jun 29, 2024
@snovak7 snovak7 self-assigned this Jun 29, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@m17kea
Copy link
Contributor

m17kea commented Oct 18, 2024

Hi Simon, any idea when this will make it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Minor changes
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

AMQP queues die when the rabbit default timeout is reached
2 participants