Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/lightning qr #95

Merged
merged 7 commits into from
Feb 22, 2025
Merged

Feat/lightning qr #95

merged 7 commits into from
Feb 22, 2025

Conversation

josefinalliende
Copy link
Contributor

@josefinalliende josefinalliende commented Feb 22, 2025 •
edited
Loading

Context

We were able to pay a lightning invoice with nwc but the message wasn't so user friendly

What has been done

  • A reply with an invoice payed message is shown when the invoice is payed via nwc, in replacement to the lightining reaction
  • The UX was improved by adding a QR code, buttons below the QR to copy and pay.
  • The invoice string was shortened to help readability
  • The QR aspect was changed after it is payed, now it has a success icon

Now it looks like this:

Screen.Recording.2025-02-22.at.2.52.11.AM.mov

@jgmontoya jgmontoya mentioned this pull request Feb 22, 2025
Closed
@josefinalliende josefinalliende marked this pull request as ready for review February 22, 2025 05:49
@erskingardner erskingardner merged commit 4b94176 into erskingardner:master Feb 22, 2025
8 of 13 checks passed
@josefinalliende josefinalliende deleted the feat/lightning-qr branch February 22, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erskingardner erskingardner erskingardner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josefinalliende @erskingardner @jgmontoya @a-mpch