Mobile styling #25
Merged
Mobile styling #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify cubit, remove socket client dependency
|
Iam sry this PR got a little bit bigger while developing, I hope its still understandable - shame on me 🙈 |
t-animal
approved these changes
Sep 19, 2022
| padding: const EdgeInsets.all(20), | ||
| child: Hero( | ||
| tag: 'coffee-cup', | ||
| child: Material( |
There was a problem hiding this comment.
Do we need the Material here? My gut feeling tells me, this should be handled by the MaterialApp in main.dart
There was a problem hiding this comment.
Jep, your right! Thats just Copy Pasta
| padding: const EdgeInsets.all(48), | ||
| return BlocBuilder<CoffeeCallCubit, CoffeeCallState>( | ||
| builder: (context, state) { | ||
| return Container( |
There was a problem hiding this comment.
Could be a padding (only use Containers if you need at least two of its properties)
There was a problem hiding this comment.
Done, thanks for the hint, makes sense :)
see #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.