Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erts: Introduce hibernate/0 and simplify hibernate/3 #9406

Merged
merged 1 commit into from
Feb 25, 2025
Merged

erts: Introduce hibernate/0 and simplify hibernate/3 #9406

merged 1 commit into from
Feb 25, 2025

Conversation

jhogberg
Copy link
Contributor

This is scheduled for RC2, I'm opening a draft PR so I don't forget about it again.

@jhogberg jhogberg added team:VM Assigned to OTP team VM feature labels Feb 10, 2025
@jhogberg jhogberg self-assigned this Feb 10, 2025
@jhogberg jhogberg requested a review from bjorng February 10, 2025 12:24
bjorng
bjorng reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@bjorng bjorng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I only have a single nitpick.

@jhogberg jhogberg force-pushed the john/erts/hibernation-improvements branch from 5fc6439 to 386a27d Compare February 11, 2025 09:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025 •
edited
Loading

CT Test Results

    3 files    141 suites   49m 47s ⏱️
1 603 tests 1 554 ✅ 49 💤 0 ❌
2 312 runs  2 243 ✅ 69 💤 0 ❌

Results for commit e3028f6.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

bjorng
bjorng previously approved these changes Feb 11, 2025
View reviewed changes
@juhlig
Copy link
Contributor

juhlig commented Feb 14, 2025

Interesting =D But shouldn't there be a proc_lib:hibernate/0 then, too? If there was, we could immediately use it in #9287, probably

@josevalim
Copy link
Contributor

@juhlig I may be wrong but the reason proc_lib:hibernate/3 exists is exactly because it has to "reinitialize" the process/stack. In this case, because the stack is preserved, there is no need for wrappers. You can just call it directly.

@juhlig juhlig mentioned this pull request Feb 15, 2025
Open
@jhogberg jhogberg marked this pull request as ready for review February 19, 2025 11:23
@jhogberg jhogberg added the testing currently being tested, tag is used by OTP internal CI label Feb 19, 2025
@jhogberg jhogberg force-pushed the john/erts/hibernation-improvements branch 2 times, most recently from 7e6cfc9 to ab1c83f Compare February 20, 2025 17:22
@jhogberg jhogberg force-pushed the john/erts/hibernation-improvements branch from ab1c83f to 72f140d Compare February 21, 2025 11:36
bjorng
bjorng previously approved these changes Feb 21, 2025
View reviewed changes
@jhogberg jhogberg force-pushed the john/erts/hibernation-improvements branch from 72f140d to e3028f6 Compare February 24, 2025 09:08
@jhogberg jhogberg merged commit 2c47049 into erlang:master Feb 25, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garazdawi garazdawi garazdawi left review comments

@bjorng bjorng bjorng approved these changes

Assignees

@jhogberg jhogberg

Labels
feature team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jhogberg @juhlig @josevalim @bjorng @garazdawi