Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example in Readme #271

Open
wants to merge 1 commit into
base: 5.0
Choose a base branch
from
Open

Fix example in Readme #271

wants to merge 1 commit into from

Conversation

e-e-e
Copy link

@e-e-e e-e-e commented Aug 1, 2018

I was scratching my head for about 30minutes as to why I could not get a label working correctly with checkbox. I was directly copying the example in the read me, but was getting erorrs in my app because FormControlLabel was undefined. I updated the import to statements and everything worked fine.

This closes #258.

@codecov
Copy link

codecov bot commented Aug 1, 2018

Codecov Report

Merging #271 into 5.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              5.0     #271   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           8        8           
  Lines          24       24           
=======================================
  Hits           16       16           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9328e93...356f12b. Read the comment docs.

@Robinnnnn
Copy link

Is this repo still being maintained? I was also stuck on this for a while and the README should be updated asap.

@brucegl
Copy link

brucegl commented Sep 21, 2018

change: import Radio from '@material-ui/core/RadioButton'
to: import Radio from '@material-ui/core/Radio'

Also, maybe rename this repo to redux-form-material-ui@next to cover v1, v3, onwards?

@e-e-e
Copy link
Author

e-e-e commented Oct 4, 2018

@erikras - any word on this - its a super small change which will help others new to your library massively.

@brucegl
Copy link

brucegl commented Oct 4, 2018

@erikras - any word on this - its a super small change which will help others new to your library massively.

A few more changes are needed, however, I just found https://youtu.be/WoSzy-4mviQ and I'm of the opinion that newbies should use react-final-form, especially as this project is active for now. If you need to use redux to use form data from outside the form, see https://github.com/final-form/react-final-form/blob/master/README.md#redux-example. @erikras does say "If you need to mutate your data via dispatching Redux actions, you should probably use Redux Form." I wonder if "probably" means that there may be a way to handle this case with react-final-form, or it could be resolved in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants