Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onUpdateInput for AutoComplete #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

onUpdateInput for AutoComplete #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/AutoComplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import createComponent from './createComponent'
import mapError from './mapError'

export default createComponent(AutoComplete, ({
input: { onChange, value },
input: { onChange, value, onUpdateInput },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onUpdateInput is not in input. input are callbacks that redux-form generates.

Copy link
Author

@sachinmour sachinmour Apr 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct.. i meant when you are overwriting the input by passing it as props..
maybe code should be more like..
if (onUpdateInput) {..}

onNewRequest,
dataSourceConfig,
dataSource,
Expand All @@ -24,8 +24,6 @@ export default createComponent(AutoComplete, ({
}
},
onUpdateInput: value => {
if (!dataSourceConfig) {
onChange(value)
}
onUpdateInput(value)
}
}))