engineapi: Add Pectra banner #13785
Merged
engineapi: Add Pectra banner #13785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratorio
reviewed
Feb 13, 2025
turbo/engineapi/engine_server.go
Outdated
| @@ -78,6 +78,7 @@ type EngineServer struct { | |||
| } | |||
|
|
|||
| const fcuTimeout = 1000 // according to mathematics: 1000 millisecods = 1 second | |||
| var printPectraBanner = true | |||
There was a problem hiding this comment.
I'd suggest to move that to EngineServer as a printPectraBanner struct attribute - it is good practice to avoid using global variables for state like this.
It also should probably be an atomic.Bool given it is set to false upon requests that can be asynchronous.
There was a problem hiding this comment.
I did that to make things as simple as possible to not have side-effects. But, I will move the var to the struct. atomic.Bool isn't needed though, because a lock is placed to the struct at the beginning of the func
taratorio
approved these changes
Feb 13, 2025
taratorio
approved these changes
Feb 13, 2025
somnathb1
added a commit
that referenced
this pull request
Feb 13, 2025
somnathb1
added a commit
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.