DOPE-239: implemented all objectFunctions with extensions for cm and added tests #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinagallati-ergon
suggested changes
Nov 13, 2024
...gon/dope/resolvable/expression/unaliased/type/function/object/ObjectInnerValuesExpression.kt
Outdated
Show resolved
Hide resolved
...ch/ergon/dope/resolvable/expression/unaliased/type/function/object/ObjectUnwrapExpression.kt
Outdated
Show resolved
Hide resolved
...rgon/dope/resolvable/expression/unaliased/type/function/object/ObjectRemoveExpressionTest.kt
Outdated
Show resolved
Hide resolved
...-map-connector/src/main/kotlin/ch/ergon/dope/extension/type/objectfunction/ObjectFunction.kt
Show resolved
Hide resolved
...-map-connector/src/main/kotlin/ch/ergon/dope/extension/type/objectfunction/ObjectFunction.kt
Show resolved
Hide resolved
...-map-connector/src/main/kotlin/ch/ergon/dope/extension/type/objectfunction/ObjectFunction.kt
Show resolved
Hide resolved
...ch/ergon/dope/resolvable/expression/unaliased/type/function/object/ObjectRenameExpression.kt
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.../ch/ergon/dope/resolvable/expression/unaliased/type/function/object/ObjectFieldExpression.kt
Show resolved
Hide resolved
.../ch/ergon/dope/resolvable/expression/unaliased/type/function/object/ObjectFieldExpression.kt
Show resolved
Hide resolved
.../ch/ergon/dope/resolvable/expression/unaliased/type/function/object/ObjectFieldExpression.kt
Show resolved
Hide resolved
.../ch/ergon/dope/resolvable/expression/unaliased/type/function/object/ObjectFieldExpression.kt
Show resolved
Hide resolved
...gon/dope/resolvable/expression/unaliased/type/function/object/ObjectInnerValuesExpression.kt
Outdated
Show resolved
Hide resolved
...-map-connector/src/main/kotlin/ch/ergon/dope/extension/type/objectfunction/ObjectFunction.kt
Show resolved
Hide resolved
...-map-connector/src/main/kotlin/ch/ergon/dope/extension/type/objectfunction/ObjectFunction.kt
Show resolved
Hide resolved
...tal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/type/object/ObjectFunctionTest.kt
Show resolved
Hide resolved
...tal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/type/object/ObjectFunctionTest.kt
Show resolved
Hide resolved
...tal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/type/object/ObjectFunctionTest.kt
Show resolved
Hide resolved
martinagallati-ergon
approved these changes
Nov 20, 2024
...gon/dope/resolvable/expression/unaliased/type/function/object/ObjectInnerValuesExpression.kt
Outdated
Show resolved
Hide resolved
jansigi
force-pushed
the
feature/dope-239-object-funcitons
branch
from
2da79e1 to
c5b7e69
Compare
pgruntz
requested changes
Dec 5, 2024
...in/ch/ergon/dope/resolvable/expression/unaliased/type/function/object/ObjectAddExpression.kt
Outdated
Show resolved
Hide resolved
...ch/ergon/dope/resolvable/expression/unaliased/type/function/object/ObjectLengthExpression.kt
Show resolved
Hide resolved
...ch/ergon/dope/resolvable/expression/unaliased/type/function/object/ObjectRenameExpression.kt
Outdated
Show resolved
Hide resolved
...ch/ergon/dope/resolvable/expression/unaliased/type/function/object/ObjectValuesExpression.kt
Outdated
Show resolved
Hide resolved
… can return array of different types
jansigi
force-pushed
the
feature/dope-239-object-funcitons
branch
from
4a74f87 to
a3b24dc
Compare
pgruntz
requested changes
Jan 28, 2025
| fun TypeExpression<ObjectType>.addAttribute(objectEntryPrimitive: ObjectEntryPrimitive<out ValidType>) = | ||
| ObjectAddExpression(this, objectEntryPrimitive) | ||
|
|
||
| fun TypeExpression<ObjectType>.addAttribute(key: TypeExpression<StringType>, value: TypeExpression<out ValidType>) = |
There was a problem hiding this comment.
there are no build/integration tests, where you play around with different typeEpressions / nested-functions etc, right? Please add some
| attributeKey: TypeExpression<StringType>, | ||
| ) : FunctionExpression<ValidType>("OBJECT_FIELD", objectExpression, attributeKey) | ||
|
|
||
| fun TypeExpression<ObjectType>.objectField(key: TypeExpression<StringType>) = |
There was a problem hiding this comment.
remove the prefix object from the extension-funciton (You are not doing .objectConcat or similar as well).
Use a more descriptive naming, like getField()? (I'm don't know what the function should do)
There was a problem hiding this comment.
(or something with Attribute?, below you use that term, would not use both for the same thing)
| objectExpression: TypeExpression<ObjectType>, | ||
| ) : FunctionExpression<ArrayType<ObjectType>>("OBJECT_INNER_PAIRS", objectExpression) | ||
|
|
||
| fun TypeExpression<ObjectType>.innerPairs() = ObjectInnerPairsExpression(this) |
There was a problem hiding this comment.
prefer to have function with a verb. Something like getInnerPairs()/createInnerPairs() or something (same for all of the functions)
There was a problem hiding this comment.
I think you should also add some integration-tests for objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.