Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOPE-255: add let clause with tests #63

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Conversation

jansigi
Copy link
Collaborator

@jansigi jansigi commented Nov 12, 2024

No description provided.

@jansigi jansigi self-assigned this Nov 12, 2024
# Conflicts:
#	crystal-map-connector/src/main/kotlin/ch/ergon/dope/extension/clause/SelectClause.kt
Copy link
Contributor

@martinagallati-ergon martinagallati-ergon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like this approach! Because it's a new clause, I would consider adding an integration test; the build test you wrote seems like a good candidate for that. What do you think?

@jansigi jansigi merged commit 39032de into main Dec 17, 2024
1 check passed
@jansigi jansigi deleted the feature/dope-255-let-clause branch December 17, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants