Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve measurement details in README for phpunit 10+ #452

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

mvorisek
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.77%. Comparing base (9740a48) to head (deece2f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #452   +/-   ##
=========================================
  Coverage     58.77%   58.77%           
  Complexity      135      135           
=========================================
  Files            33       33           
  Lines           701      701           
=========================================
  Hits            412      412           
  Misses          289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mvorisek
Copy link
Contributor Author

Firstly, thank you for merging the #380 PR!

I did my best to improve the README for new users, especially to stress:

  • the before/after class test methods are measured only when phpunit process isolation is enabled
  • remove the notes telling the durations might vary on a tests order, this is not true

@localheinz localheinz self-assigned this Jan 15, 2024
@mvorisek
Copy link
Contributor Author

@localheinz is this PR welcomed?

@mvorisek
Copy link
Contributor Author

@localheinz are you interested in this README improvement or should I close this PR?

@localheinz
Copy link
Member

Apologies for the delay, I’m busy with closed-source projects at the moment. Will take a look later in the year!

@localheinz localheinz merged commit 70a9437 into ergebnis:main Feb 23, 2025
75 checks passed
@localheinz
Copy link
Member

Thank you, @mvorisek!

@mvorisek mvorisek deleted the fix_readme branch February 23, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants