Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[Before] attribute should not be private in final classes #863

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

cosmastech
Copy link
Contributor

@cosmastech cosmastech commented Nov 17, 2024

This pull request

  • Allows #[Before] to remain protected
  • Adds test

Follows #.
Related to #.
Fixes #845

@cosmastech
Copy link
Contributor Author

Appreciate some guidance on if you want to follow something similar to how NoExtendsRule receives an array of class strings, or if there's something else I should do.

thanks for the plugin!

@cosmastech cosmastech marked this pull request as ready for review November 17, 2024 13:47
@cosmastech cosmastech changed the title #[Before] attribute should not be final #[Before] attribute should not be private in final classes Nov 17, 2024
@localheinz localheinz self-assigned this Nov 22, 2024
@localheinz localheinz force-pushed the patch-1 branch 4 times, most recently from 12be9df to a93c67c Compare January 7, 2025 12:49
@localheinz localheinz changed the title #[Before] attribute should not be private in final classes #[Before] attribute should not be private in final classes Jan 7, 2025
@localheinz localheinz merged commit 44d89ef into ergebnis:main Jan 7, 2025
23 checks passed
@localheinz
Copy link
Member

Thank you, @cosmastech!

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (a95714d) to head (efbc9f8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #863      +/-   ##
============================================
+ Coverage     97.39%   97.44%   +0.04%     
- Complexity      209      214       +5     
============================================
  Files            23       23              
  Lines           729      743      +14     
============================================
+ Hits            710      724      +14     
  Misses           19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrivateInFinalClassRule throws false positive when using PHPUnit attribute #[Before]
2 participants