Merge pull request #898 from ergebnis/fix/php-parser

Fix: Remove `nikic/php-parser`
ergebnis · Jan 8, 2025 · f2867c9 · f2867c9
2 parents 5b7b4c0 + 5474c3c
commit f2867c9
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 16 deletions.
diff --git a/composer.json b/composer.json
@@ -32,7 +32,6 @@
     "ergebnis/php-cs-fixer-config": "^6.39.0",
     "ergebnis/phpunit-slow-test-detector": "^2.17.0",
     "nette/di": "^3.1.10",
-    "nikic/php-parser": "^4.19.4",
     "phpstan/extension-installer": "^1.4.3",
     "phpstan/phpstan-deprecation-rules": "^2.0.1",
     "phpstan/phpstan-phpunit": "^2.0.3",

diff --git a/composer.lock b/composer.lock
diff --git a/src/Classes/FinalRule.php b/src/Classes/FinalRule.php
@@ -134,10 +134,6 @@ private function hasWhitelistedAnnotation(Node\Stmt\Class_ $node): bool
 
         $reformattedComment = $docComment->getReformattedText();
 
-        if (!\is_string($reformattedComment)) {
-            return false;
-        }
-
         if (\is_int(\preg_match_all('/@(\S+)(?=\s|$)/', $reformattedComment, $matches))) {
             foreach ($matches[1] as $annotation) {
                 foreach (self::$whitelistedAnnotations as $whitelistedAnnotation) {

diff --git a/src/Classes/PHPUnit/Framework/TestCaseWithSuffixRule.php b/src/Classes/PHPUnit/Framework/TestCaseWithSuffixRule.php
@@ -58,7 +58,6 @@ public function processNode(
             return [];
         }
 
-        /** @var string $fullyQualifiedClassName */
         $fullyQualifiedClassName = $node->namespacedName->toString();
 
         $classReflection = $this->reflectionProvider->getClass($fullyQualifiedClassName);