Skip to content

Commit

Permalink
Fix: Add more test cases
Browse files Browse the repository at this point in the history
  • Loading branch information
localheinz committed Jan 8, 2025
1 parent 9bcbbf7 commit b8992e4
Show file tree
Hide file tree
Showing 15 changed files with 94 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,11 @@
$qux = function (): null|string {
return 'Hello';
};

$quux = function (): nUlL|string {
return 'Hello';
};

$quz = function (): \null|string {
return 'Hello';
};
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
return $bar;
};

$quux = function ($bar = \null) {
$quux = function ($bar = nUlL) {
return $bar;
};

$quz = function ($bar = NuLl) {
$quz = function ($bar = \null) {
return $bar;
};
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,11 @@
$quux = function (null|string $bar) {
return $bar;
};

$quz = function (nUlL|string $bar) {
return $bar;
};

$corge = function (\null|string $bar) {
return $bar;
};
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,13 @@ function quux(): null|string
{
return 'Hello';
}

function quz(): nUlL|string
{
return 'Hello';
}

function corge(): \null|string
{
return 'Hello';
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ function qux($bar = null)
return $bar;
}

function quux($bar = \null)
function quux($bar = nUlL)
{
return $bar;
}

function quz($bar = nUlL)
function quz($bar = \null)
{
return $bar;
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,13 @@ function quux(null|string $bar)
{
return $bar;
}

function quz(nUlL|string $bar)
{
return $bar;
}

function corge(\null|string $bar)
{
return $bar;
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,17 @@ public function toString(): null|string
return 'Hello';
}
};

$quux = new class() {
public function toString(): nUlL|string
{
return 'Hello';
}
};

$quz = new class() {
public function toString(): \null|string
{
return 'Hello';
}
};
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ public function foo($bar = null)
};

$quux = new class() {
public function foo($bar = \null)
public function foo($bar = nUlL)
{
return $bar;
}
};

$quz = new class() {
public function foo($bar = NuLl)
public function foo($bar = \null)
{
return $bar;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,17 @@ public function foo(null|string $bar)
}
};

$quz = new class() {
public function foo(nUlL|string $bar)
{
return $bar;
}
};

$corge = new class() {
public function foo(\null|string $bar)
{
return $bar;
}
};

Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ public function testNoNullableReturnTypeDeclarationRule(): void
'Closure has a nullable return type declaration.',
19,
],
[
'Closure has a nullable return type declaration.',
23,
],
],
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ public function testNoParameterWithNullableTypeDeclarationRule(): void
'Closure has parameter $bar with a nullable type declaration.',
22,
],
[
'Closure has parameter $bar with a nullable type declaration.',
26,
],
],
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ public function testNoNullableReturnTypeDeclarationRule(): void
'Function Ergebnis\PHPStan\Rules\Test\Fixture\Functions\NoNullableReturnTypeDeclarationRule\quux() has a nullable return type declaration.',
22,
],
[
'Function Ergebnis\PHPStan\Rules\Test\Fixture\Functions\NoNullableReturnTypeDeclarationRule\quz() has a nullable return type declaration.',
27,
],
],
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ public function testNoParameterWithNullableTypeDeclarationRule(): void
'Function Ergebnis\PHPStan\Rules\Test\Fixture\Functions\NoParameterWithNullableTypeDeclarationRule\quux() has parameter $bar with a nullable type declaration.',
26,
],
[
'Function Ergebnis\PHPStan\Rules\Test\Fixture\Functions\NoParameterWithNullableTypeDeclarationRule\quz() has parameter $bar with a nullable type declaration.',
31,
],
],
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ public function testNoNullableReturnTypeDeclarationRule(): void
'Method toString() in anonymous class has a nullable return type declaration.',
29,
],
[
'Method toString() in anonymous class has a nullable return type declaration.',
36,
],
],
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ public function testNoParameterWithNullableTypeDeclarationRule(): void
'Method foo() in anonymous class has parameter $bar with a nullable type declaration.',
35,
],
[
'Method foo() in anonymous class has parameter $bar with a nullable type declaration.',
42,
],
],
);
}
Expand Down

0 comments on commit b8992e4

Please sign in to comment.