Enhancement: Extract method

ergebnis · Jan 6, 2025 · 56fe987 · 56fe987
1 parent fb58818
commit 56fe987
Showing 1 changed file with 19 additions and 11 deletions.
diff --git a/src/Methods/PrivateInFinalClassRule.php b/src/Methods/PrivateInFinalClassRule.php
@@ -50,17 +50,8 @@ public function processNode(
 
         $methodName = $node->name->toString();
 
-        $parentClass = $containingClass->getNativeReflection()->getParentClass();
-
-        if (
-            $parentClass instanceof \ReflectionClass
-            && $parentClass->hasMethod($methodName)
-        ) {
-            $parentMethod = $parentClass->getMethod($methodName);
-
-            if ($parentMethod->isProtected()) {
-                return [];
-            }
+        if (self::methodIsDeclaredByParentClass($containingClass, $methodName)) {
+            return [];
         }
 
         /** @var Reflection\ClassReflection $classReflection */
@@ -91,4 +82,21 @@ public function processNode(
                 ->build(),
         ];
     }
+
+    private static function methodIsDeclaredByParentClass(
+        Reflection\ClassReflection $containingClass,
+        string $methodName
+    ): bool {
+        $parentClass = $containingClass->getNativeReflection()->getParentClass();
+
+        if (!$parentClass instanceof \ReflectionClass) {
+            return false;
+        }
+
+        if (!$parentClass->hasMethod($methodName)) {
+            return false;
+        }
+
+        return true;
+    }
 }