Fix test cases for new normalisation rules #985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the discussion in #704, it seems that this particular key ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test cases claim to be "already normalized". According to the rules in version 2.x of
ergebnis/json-normalizerthey are normalised and all is well. However, according to the rules in version 3.x ofergebnis/json-normalizer, they are not yet normalised. Changing them now makes no difference to the test-suite, however, with the files as they are, the test suite fails on #956; after this pull request has been merged, the test suite in #956 will pass, which should allow that to be merged in.Related to #956 and #868.