Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against Python 3.11 #645

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Test against Python 3.11 #645

merged 1 commit into from
Jan 24, 2024

Conversation

mferrera
Copy link
Collaborator

@mferrera mferrera commented Jan 9, 2024

Resolves #644

@mferrera mferrera self-assigned this Jan 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e40c54) 86.11% compared to head (28cfba5) 86.11%.

❗ Current head 28cfba5 differs from pull request most recent head 217cdb6. Consider uploading reports for the commit 217cdb6 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #645   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files          50       50           
  Lines        7058     7058           
=======================================
  Hits         6078     6078           
  Misses        980      980

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mferrera
Copy link
Collaborator Author

mferrera commented Jan 9, 2024

Blocked by res2df

@mferrera mferrera force-pushed the add-py11-py12 branch 2 times, most recently from 253f288 to c670c28 Compare January 23, 2024 10:11
@mferrera mferrera changed the title Test against Python 3.11 and 3.12 Test against Python 3.11 Jan 23, 2024
@mferrera mferrera marked this pull request as ready for review January 24, 2024 09:09
@mferrera mferrera requested a review from rnyb January 24, 2024 09:16
@mferrera mferrera requested a review from alifbe January 24, 2024 09:26
alifbe
alifbe approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mferrera mferrera merged commit 6383820 into main Jan 24, 2024
6 checks passed
@mferrera mferrera deleted the add-py11-py12 branch January 24, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alifbe alifbe alifbe approved these changes

@rnyb rnyb Awaiting requested review from rnyb

Assignees

@mferrera mferrera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Python 3.11 testing
3 participants
@mferrera @codecov-commenter @alifbe