Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated support for implicit mkdir in sunsch #638

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

berland
Copy link
Collaborator

@berland berland commented Jan 3, 2024

Has been deprectated for three years, 8bfc5bd

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (16b8d8c) 85.38% compared to head (91f37e7) 86.13%.

❗ Current head 91f37e7 differs from pull request most recent head 1896480. Consider uploading reports for the commit 1896480 to get more accurate results

Files Patch % Lines
src/subscript/sunsch/sunsch.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
+ Coverage   85.38%   86.13%   +0.74%     
==========================================
  Files          49       49              
  Lines        7054     7053       -1     
==========================================
+ Hits         6023     6075      +52     
+ Misses       1031      978      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland self-assigned this Jan 3, 2024
@berland berland requested a review from alifbe January 3, 2024 12:22
Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@berland berland merged commit 6c42a88 into equinor:main Jan 3, 2024
4 checks passed
@berland berland deleted the rm_sunsch_mkdir branch February 11, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants