Remove co2_containment code, has been moved to new repo ccs-scripts

[AudunSektnanNR]

No description provided.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47f93ad) 84.70% compared to head (05e7ddd) 86.14%.

❗ Current head 05e7ddd differs from pull request most recent head 652b4c1. Consider uploading reports for the commit 652b4c1 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
+ Coverage   84.70%   86.14%   +1.44%     
==========================================
  Files          52       49       -3     
  Lines        7510     7054     -456     
==========================================
- Hits         6361     6077     -284     
+ Misses       1149      977     -172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mferrera]

Will this script reach Komodo stable from ccs-scripts from the November release, or December release?

[AudunSektnanNR]

It is not included in the November release, but will be included in the December release. Currently it is only on komodo bleeding.

We thought it would be best to remove the code from subscript in case it created some kind of conflict for the co2_containment code (subscript vs ccs-scripts)? Or is this unproblematic since it is from packages/repos with different names? Note that we haven't yet registered the code in ccs-scripts as plugin for ERT.

[mferrera]

If co2_containment as a command line invocation exists both here and in ccs-scripts in stable, then running co2_containment may call it from either here or ccs-scripts, but won't cause any problems otherwise. It depends mostly on the order in which Komodo installs it -- the latter one taking precedence.

So it makes a meaningful difference if co2_containment has been changed or updated in ccs-scripts, but otherwise doesn't really matter.

I guess, taking this in today, we could propose a second upgraded version for December. I think it should be okay.

[mferrera]

subscript/docs/overview.rst

Line 13 in 47f93ad

co2_containment ✅ ⛔️ ⛔️

Please also remove here and then I think it's good to go 😄

[AudunSektnanNR]

If co2_containment as a command line invocation exists both here and in ccs-scripts in stable, then running co2_containment may call it from either here or ccs-scripts, but won't cause any problems otherwise. It depends mostly on the order in which Komodo installs it -- the latter one taking precedence.

So it makes a meaningful difference if co2_containment has been changed or updated in ccs-scripts, but otherwise doesn't really matter.

I guess, taking this in today, we could propose a second upgraded version for December. I think it should be okay.

Thanks for answer, yes there have been some new changes in ccs-scripts for co2_containment, so it will not be indentical to the version in subscript

[mferrera]

Unfortunately we've passed the freeze window now so these changes will come into Komodo stable in the January release.