add support for FailurePolicy in job spec #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nilsgstrabo
commented
Dec 12, 2024
•
nilsgstrabo
commented
- update radix-operator ref to v1.67.0
- update to alpine 3.21
- create local models for Node, Resources and FailurePolicy instead of using radixv1 structs -> well defined openapi schema
- update tests
satr
reviewed
Dec 13, 2024
models/common/resources.go
Outdated
|
|
||
| type ResourceList map[string]string | ||
|
|
||
| // ResourceRequirements describes the compute resource requirements. |
satr
reviewed
Dec 13, 2024
| // Node defines node attributes, where container should be scheduled | ||
| // | ||
| // required: false | ||
| Node *v1.RadixNode `json:"node,omitempty"` | ||
| Node *Node `json:"node,omitempty"` |
There was a problem hiding this comment.
Maybe this need to consistent with radix-operator type https://github.com/equinor/radix-operator/blob/6c95cb419117d8ffa948fb9802230805958d86d3/pkg/apis/radix/v1/radixapptypes.go#L434
There was a problem hiding this comment.
What is inconsistent?
satr
previously approved these changes
Dec 13, 2024
satr
approved these changes
Dec 13, 2024
nilsgstrabo
deleted the
145-add-support-for-defining-custom-failurepolicy-per-job-and-batch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.