-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(requirements): bump dependencies, mainly to eliminate third-party security issues #1383
Merged
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
71a54ff
Fix(requirements): bump dependencies, mainly to eliminate third-party…
RollerKnobster 4064a8e
Fix(requirements): bump test dependencies, mainly to eliminate third-…
RollerKnobster 695c592
Fix(requirements): use scikeras to bring back keras wrappers
RollerKnobster 9a75758
Fix: apply formatting
RollerKnobster 01eac86
Fix: add `super().__init__(**kwargs)` call to `KerasBaseEstimator`
RollerKnobster d6faadc
Fix: rename `build_fn` to `model`
RollerKnobster d47855e
Fix: move `super().__init__(**kwargs)` to start of `KerasBaseEstimato…
RollerKnobster 77bc40c
Fix: i'm done with comments for now
RollerKnobster bede872
Fix: remove redundant `BaseEstimator` inheritance in `KerasBaseEstima…
RollerKnobster 06de56f
Fix: remove redundant `BaseWrapper` alias for `KerasRegressor`
RollerKnobster 5eee699
Fix: add super call to KerasBaseEstimator
RollerKnobster 3b2bca3
Fix: no comments
RollerKnobster 78fde46
Fix: refactor `__call__` method of models to `_prepare_model`
RollerKnobster 31a59a8
Fix: move assignment of `kind` above the `_prepare_model` call
RollerKnobster eaf24b2
Fix: prepare model right before calling fit in keras models
RollerKnobster 757d207
Fix: rename `self.history` to `self._history` in `KerasBaseEstimator`
RollerKnobster b64dc08
Fix: rename `self.kind` and `self.kwargs` to `self._kind` and `self._…
RollerKnobster fe3530b
Fix: refactor `getattr(keras.optimizers, optimizer)` to `keras.optimi…
RollerKnobster 9200d07
Fix: refactor `getattr(keras.optimizers, optimizer)` to `keras.optimi…
RollerKnobster 3f2a313
Fix: refactor `getattr(keras.optimizers, optimizer)` to `keras.optimi…
RollerKnobster c520dbb
Fix: remove `save_format` param from `save_model` in `KerasBaseEstima…
RollerKnobster b93af57
Fix: remove `save_format` param from `save_model` in `KerasBaseEstima…
RollerKnobster 3696b11
Fix: formatting
RollerKnobster 92a537f
Fix: change saving to tempfile
RollerKnobster 7c8c140
Fix: formatting
RollerKnobster 0150f0f
Fix: save model as .keras temp file
RollerKnobster 8f738fb
Fix: save model as .keras temp file
RollerKnobster a8dbb8c
Fix: save model as .keras temp file
RollerKnobster 7f4e2b3
Fix: load model as .keras temp file
RollerKnobster 5920784
Fix: load model as .keras temp file
RollerKnobster f138c27
Fix: load model as .keras temp file
RollerKnobster c6000a2
Fix: adjust test for argo versions
RollerKnobster dd2f98a
Fix: save bytes instead of bytesio to model state
RollerKnobster 0c2aef8
Fix: skip loading unitialized model from state
RollerKnobster c2dbc6b
Fix: adjust test for serializer
RollerKnobster 0ca65e3
Fix: adjust test for serializer
RollerKnobster 8432d16
Fix: rename `KerasLSTMBaseEstimator` attributes to underscored prefixed
RollerKnobster 45155e4
Fix: rename `KerasLSTMBaseEstimator` attributes to underscored prefixed
RollerKnobster a7ba4fc
Fix: do not propagate kwargs to `super().__init__` of KerasBaseEstimator
RollerKnobster c97c5a5
Fix: do not propagate kwargs to `super().__init__` of KerasBaseEstimator
RollerKnobster ba15f75
Fix: do not propagate kwargs to `super().__init__` of KerasBaseEstimator
RollerKnobster 17ad386
Fix: do not propagate kwargs to `super().__init__` of KerasBaseEstimator
RollerKnobster 033d2df
Fix: propagate batch_size to `super().__init__` of KerasBaseEstimator
RollerKnobster aca1630
Fix: set `input_shape` to tensorflow layers definition in `KerasRawMo…
RollerKnobster 96ba313
Fix: store history for model in `_history` and use proper `regressor_…
RollerKnobster 796f9a1
Fix: formatting
RollerKnobster e25a71e
Fix: adjust `model` and `history` attributes access in `KerasBaseEsti…
RollerKnobster 6852cbc
Fix: adjust `lstm` `optimizer_kwargs` and `input.shape` access
RollerKnobster 6d827e6
Fix: add input_shape to Dense layers in kerasraw test
RollerKnobster 657d6e9
Merge with main
RollerKnobster ad19212
Formatting
RollerKnobster e94c9f6
Formatting
RollerKnobster 1fd82d5
Add gunicorn as base requirement
RollerKnobster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
mlflow~=2.14 | ||
azureml-core~=1.49 | ||
azureml-core~=1.56.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,14 @@ | ||
dictdiffer~=0.8 | ||
dataclasses-json~=0.3 | ||
gunicorn~=22.0 | ||
jinja2~=3.1 | ||
python-dateutil~=2.8 | ||
tensorflow~=2.16.0 | ||
scikeras~=0.13.0 | ||
gunicorn~=22.0 | ||
# There's a bug in keras 3.4.0 with loading models (https://github.com/keras-team/keras/issues/19921) | ||
keras<3.4.0 | ||
Flask>=2.2.5,<3.0.0 | ||
simplejson~=3.17 | ||
prometheus_client~=0.7 | ||
# Due to azureml-core 1.49.0 depends on packaging<22.0 | ||
packaging>=21.0,<22.0 | ||
packaging>=24.0 | ||
gordo-client~=6.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep this dependency. I know this is a transitional dependency through mlflow, but mlflow is extras_require. A user can install gordo without it