Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various tracking issues #1970

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Fix various tracking issues #1970

merged 7 commits into from
Jan 21, 2025

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Jan 20, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@andchiind andchiind marked this pull request as ready for review January 21, 2025 08:46
@andchiind andchiind force-pushed the debug-tracking branch 2 times, most recently from f8b2b4c to 7f5dd5c Compare January 21, 2025 10:03
@andchiind andchiind force-pushed the debug-tracking branch 2 times, most recently from e93cadb to 7f067d2 Compare January 21, 2025 10:12
Christdej
Christdej approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeshub aeshub added the bug Something isn't working label Jan 21, 2025
aeshub
aeshub approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@aeshub aeshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Too

@andchiind andchiind merged commit 18b8aa7 into equinor:main Jan 21, 2025
12 checks passed
@andchiind andchiind deleted the debug-tracking branch January 21, 2025 11:08
mrica-equinor
mrica-equinor reviewed Jan 21, 2025
View reviewed changes
backend/api/Services/RobotModelService.cs
@@ -101,7 +102,7 @@ public async Task<RobotModel> Update(RobotModel robotModel)
return robotModel;
}

public void DetachTracking(RobotModel robotModel)
public void DetachTracking(FlotillaDbContext context, RobotModel robotModel)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you pass context but use _context instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrica-equinor mrica-equinor mrica-equinor left review comments

@Christdej Christdej Christdej approved these changes

@aeshub aeshub aeshub approved these changes

Assignees

@andchiind andchiind

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andchiind @aeshub @Christdej @mrica-equinor