New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Localization bug #1418

Merged

UsamaEquinorAFK merged 4 commits into equinor:main from UsamaEquinorAFK:localization_bug

Feb 16, 2024

Contributor

UsamaEquinorAFK commented Feb 14, 2024

No description provided.

github-actions bot commented Feb 14, 2024

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

UsamaEquinorAFK mentioned this pull request

Fix localization bug #1417

Closed

UsamaEquinorAFK requested a review from andchiind

February 14, 2024 11:00

UsamaEquinorAFK force-pushed the localization_bug branch from a1acb10 to f431a49 Compare

February 14, 2024 12:09

UsamaEquinorAFK requested review from oysand and tsundvoll

February 14, 2024 12:10

UsamaEquinorAFK self-assigned this

UsamaEquinorAFK mentioned this pull request

Use MissionRunPriority for localisation MissionRuns #1413

Closed

tsundvoll approved these changes

View reviewed changes

Contributor

tsundvoll left a comment

Remember to check if migration is needed

UsamaEquinorAFK force-pushed the localization_bug branch from f431a49 to 1bb56a7 Compare

February 15, 2024 09:53

github-actions bot commented Feb 15, 2024

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

github-actions bot added the database-change label

oysand reviewed

View reviewed changes

backend/api/Migrations/20240215095201_MissionRunPriorityLocalization.cs Outdated Show resolved Hide resolved

oysand requested changes

View reviewed changes

Contributor

oysand left a comment

Remove migrations

UsamaEquinorAFK force-pushed the localization_bug branch from 1bb56a7 to 4abea80 Compare

February 15, 2024 09:58

oysand reviewed

View reviewed changes

backend/api/EventHandlers/MissionEventHandler.cs Outdated Show resolved Hide resolved

oysand reviewed

View reviewed changes

backend/api/EventHandlers/MissionEventHandler.cs Outdated Show resolved Hide resolved

oysand reviewed

View reviewed changes

backend/api/EventHandlers/MissionEventHandler.cs Outdated Show resolved Hide resolved

UsamaEquinorAFK force-pushed the localization_bug branch from 4abea80 to 615172f Compare

February 15, 2024 10:22

oysand reviewed

View reviewed changes

backend/api/Services/LocalizationService.cs Outdated Show resolved Hide resolved

oysand reviewed

View reviewed changes

backend/api/EventHandlers/MissionEventHandler.cs Outdated Show resolved Hide resolved

MuhammadUsama-afk-equinor added 3 commits

February 16, 2024 09:22


          Add Localization to MissionRunPriority

b1d7e23


          Add read localization mission to MissionRunService

a038177


          Run Localization missions prior to emergency and normal missions

0938c69

UsamaEquinorAFK force-pushed the localization_bug branch 2 times, most recently from 672fe74 to 2ea44a1 Compare

February 16, 2024 08:53

UsamaEquinorAFK requested review from tsundvoll and oysand

February 16, 2024 08:54


          Refactor and add guard statement in MissionEventHandler

d9c2a1a

UsamaEquinorAFK force-pushed the localization_bug branch from 2ea44a1 to d9c2a1a Compare

February 16, 2024 08:56

oysand approved these changes

View reviewed changes

Contributor

oysand left a comment

LGTM

UsamaEquinorAFK merged commit 4ad59b1 into equinor:main

11 checks passed

UsamaEquinorAFK mentioned this pull request

Localization mission is not always placed first in the queue #1352

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database-change