Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clipboard-win to 4.2.1 #11

Closed
wants to merge 2 commits into from

Conversation

stevanmilic
Copy link

By updating the clipboard-win we resolve the issue #9.

Also some of the code has been simplified, since new clipboard-win
version has simplified API.

@stevanmilic
Copy link
Author

@equalsraf I've made some improvements that resolves the #9 issue, can you please check the code?

@SamSaffron
Copy link

Confirming this fixed #9 for me 🎊 🎊 🎊

Thank you @stevanmilic !

@equalsraf
Copy link
Owner

I am seeing a test failure for this where the clipboard is not set

https://ci.appveyor.com/project/equalsraf/win32yank/builds/42380293/job/36qim4mhletcn4ob

@elevin72
Copy link

elevin72 commented Oct 30, 2022

I am seeing a test failure for this where the clipboard is not set

https://ci.appveyor.com/project/equalsraf/win32yank/builds/42380293/job/36qim4mhletcn4ob

Here's an odd question. In actual use is it possible to copy an empty string? I understand that the test isn't passing. My understanding is that if you give set_clipboard() an empty string it just won't actually do the set. (See https://github.com/DoumanAsh/clipboard-win/blob/02a16b5dfc92cf7f8897c4aaa4e8e56fab883326/src/raw.rs#L281)
But where in actual use cases is it possible to copy an empty string?

@equalsraf
Copy link
Owner

Closing, merged #16

@equalsraf equalsraf closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants