fix(gateway): add transactions should not timeout #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko-von-Leipzig
force-pushed
the
1839-gateway-remove-timeouts-from-write-api
branch
from
e8975a8 to
b290b74
Compare
kkovaacs
approved these changes
Mar 12, 2024
Mirko-von-Leipzig
deleted the
1839-gateway-remove-timeouts-from-write-api
branch
kkovaacs
pushed a commit
that referenced
this pull request
Mar 14, 2024
…m-write-api fix(gateway): add transactions should not timeout
kkovaacs
pushed a commit
that referenced
this pull request
Mar 14, 2024
…m-write-api fix(gateway): add transactions should not timeout
kkovaacs
added a commit
that referenced
this pull request
Mar 14, 2024
Apply PR #1862 onto the 0.11.3 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the timeout from the RPC write transaction submissions to the gateway.
This is done in a somewhat clumsy fashion by adding a timeout to those methods and setting it to
MAXto override the builtin timeout from the client.Ideally we would refactor this to make all of these things much simpler again.
Unsure how to test this properly.
Fixes #1839