-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): trivial methods using new serialization trait #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df3dff3
to
d09003b
Compare
fae0027
to
e83d20f
Compare
sistemd
reviewed
Mar 12, 2024
sistemd
approved these changes
Mar 12, 2024
kkovaacs
reviewed
Mar 12, 2024
kkovaacs
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the dbg!()
@sistemd already pointed out.
No tests included since its so simple.
e83d20f
to
30c5e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements some of the simpler RPC methods using the new trait.
Note that this explicly targets RPC v0.7-rc2 only. No backwards compatibility yet - let's fully support v0.7 and then we can work backwards. This let's us skip work for v0.4 and v0.5 if we manage to remove them before this work gets there.
Particular review focus should be on the correctness of the DTO serialization ito inner types being used. i.e. ensure that if the spec says
BLOCK_HASH
is aFELT
then the serialization implementation should useserialize(&Felt(...))
.There isn't really a super easy way to enforce this apart from rigorous manual auditing when adding/updating DTOs.
Adds DTO implementations for:
and implements methods
Part of #1830