Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the about page #365

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Fix the about page #365

merged 2 commits into from
Nov 27, 2023

Conversation

richard-cox
Copy link
Member

Summary

Fixes #309

Occurred changes and/or fixed issues

  • previously header icon and link text were rancher based
  • fix the header by moving the about page to side nav
    • previously this used the plain layout
    • the plain layout has a hardcoded rancher image (except in standalone mode)
    • for simplicity just change the about page to a default layout, which means it goes in side nav
    • annoying this needs to be in a side nav group, otherwise menu item appears above service and advanced groups
  • fix link text by avoiding getVendor when not in standalone

Areas or cases that should be tested

  • about page in embedded / ui extension world
  • about page in standalone world

Screenshot/Video

image

- previously header icon and link text were rancher based
- fix the header by moving the about page to side nav
  - previously this used the `plain` layout
  - the plain layout has a hardcoded rancher image (except in standalone mode)
  - for simplicity just change the about page to a default layout, which means it goes in side nav
  - annoying this needs to be in a side nav group, otherwise menu item appears above service and advanced groups
- fix link text by avoiding getVendor when not in standalone
@richard-cox richard-cox added this to the v1.12.0 milestone Nov 20, 2023
@richard-cox richard-cox self-assigned this Nov 20, 2023
@richard-cox richard-cox requested a review from torchiaf November 20, 2023 14:43
Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit 59c89a8 into epinio:main Nov 27, 2023
5 checks passed
@richard-cox richard-cox deleted the fix-about-page branch November 27, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] Links from Epinio Extension for downloading epinio CLI pointing to rancher instead
2 participants