RFC: Fix external triggering #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2021 15:09
Not a critical fix, but I managed to trigger an exception while manually testing the behaviour of Input Mapping registers. There are 2 SEQ bits, not 4. Because of MASK being too big, if two bits left of SEQ are set for some reason evgInput::setSeqTrigMap throws exception after being called from EvgSeqManager::mapTriggerSrc.
mapTriggerSrc goes through all evgInput-s, and sets the SEQx bit for one evgInput, and *unsets* it for all other evgInputs. On mtca-EVM-300 32bit registers 0x500 through 0x51C refer to the same register. So unsetting/setting the SEQ0 bit at 0x500, will unset/set it at 0x504, 0x508... 0x50C. Because conf_mtca_evm_300 sets numFrontInp=3, EvgSeqManager::mapTriggerSrc will go through registers 0x500, 0x504 and 0x508 (among others) treating them as if they were separate registers. After setting the SEQ bit at 0x500, it will unset it at 0x504, thus undoing its work.
|
there is problem with two database files, which have FrontInp0 & FrontInp1 hardcoded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit messages and #55 for details.