Skip to content

Commit

Permalink
[fix] shell options with meteor install
Browse files Browse the repository at this point in the history
Since grep returns an exit status of 1 when it doesn't find any match, it can
cause -e to terminate the script even when there wasn't a real "error".
  • Loading branch information
williambelle committed Jan 23, 2025
1 parent ad6aeb4 commit 73aec83
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Test

on: [push, pull_request]

env:
METEOR_VERSION: 3.0-rc.4

jobs:
test:
runs-on: ubuntu-latest
Expand All @@ -25,7 +28,7 @@ jobs:

- name: Install meteor
run: |
curl https://install.meteor.com | /bin/sh
curl https://install.meteor.com/?release=$METEOR_VERSION | sh
- name: Test
run: |
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM ubuntu:focal
ENV METEOR_VERSION=3.0-rc.4

RUN apt -qy update && apt -qy install curl build-essential python3 git
RUN curl https://install.meteor.com/?release=$METEOR_VERSION | bash -e -x
RUN curl https://install.meteor.com/?release=$METEOR_VERSION | sh

COPY ./app /usr/src/app/
WORKDIR /usr/src/app/
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-dev
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ RUN apt-get -yqq update \
make \
&& apt-get clean && rm -rf /var/lib/apt/lists/*

RUN curl https://install.meteor.com/?release=$METEOR_VERSION | bash -e -x
RUN curl https://install.meteor.com/?release=$METEOR_VERSION | sh
ENV PATH=$PATH:/root/.meteor

WORKDIR /app
Expand Down

0 comments on commit 73aec83

Please sign in to comment.