Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add erc20(usdt) test with btc as based token #59

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

taokayan
Copy link
Contributor

@taokayan taokayan commented Oct 7, 2024

Resolves #38

@taokayan taokayan requested a review from yarkinwho October 7, 2024 07:25
@@ -36,4 +37,4 @@ add_eosio_test_executable( unit_test
)
add_dependencies(unit_test contracts)
# TODO: add back eos-vm-oc once change to disable EOS VM OC subjective limits during unit test are added
add_test(NAME erc20_tests COMMAND unit_test --report_level=detailed --color_output )
add_test(NAME erc20_tests COMMAND unit_test --report_level=detailed --color_output --log_level=test_suite )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

constexpr eosio::chain::name btc_token_account {"btcbtcbtcbtc"_n};
const eosio::chain::symbol btc_symbol{8, "BTC"};

struct diff_gas_token_tester : erc20_tester {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we can run same set of test twice with different tokens and settings. But i am not sure if this is easy. If not, it should be fine to have separate test files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems not that easy. let's skip it for now.

@taokayan taokayan merged commit dd529ec into main Oct 16, 2024
4 checks passed
@taokayan taokayan deleted the kayan_btc_based_test branch October 16, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update test coverage to support a different gas token than EOS
2 participants