-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add erc20(usdt) test with btc as based token #59
Conversation
@@ -36,4 +37,4 @@ add_eosio_test_executable( unit_test | |||
) | |||
add_dependencies(unit_test contracts) | |||
# TODO: add back eos-vm-oc once change to disable EOS VM OC subjective limits during unit test are added | |||
add_test(NAME erc20_tests COMMAND unit_test --report_level=detailed --color_output ) | |||
add_test(NAME erc20_tests COMMAND unit_test --report_level=detailed --color_output --log_level=test_suite ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
constexpr eosio::chain::name btc_token_account {"btcbtcbtcbtc"_n}; | ||
const eosio::chain::symbol btc_symbol{8, "BTC"}; | ||
|
||
struct diff_gas_token_tester : erc20_tester { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we can run same set of test twice with different tokens and settings. But i am not sure if this is easy. If not, it should be fine to have separate test files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems not that easy. let's skip it for now.
Resolves #38