-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buy/Sell RAM Notifications and Logging #103
Buy/Sell RAM Notifications and Logging #103
Conversation
confirm logging using |
Changed to merge into branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, to merge into ram_actions
branch. Test coverage covered in other PRs, and test coverage will be reviewed and verified before integration into main
branch.
|
||
// logging | ||
system_contract::logbuyram_action logbuyram_act{ get_self(), { {get_self(), active_permission} } }; | ||
logbuyram_act.send( payer, receiver, quant, bytes_out, res_itr->ram_bytes ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth testing this? Pushing the top level action and then checking for the inline actions executed?
|
||
// logging | ||
system_contract::logsellram_action logsellram_act{ get_self(), { {get_self(), active_permission} } }; | ||
logsellram_act.send( account, tokens_out, bytes, res_itr->ram_bytes ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth testing this? Pushing the top level action and then checking for the inline actions executed?
4d51a17
into
eosnetworkfoundation:ram_actions
Split system tests so that they can run in parallel
Change Description
Add buy RAM logging by including additional inline actions and notifications via the use of
require_recipient
.bytes
&quant
are computed values based on Bancor algorithm market.This allows
payer
orreceiver
to confirm exact bytes sent/received via notifications.API Changes
require_recipient(receiver)
onbuyram
&buyrambytes
actionsACTION:
logbuyram
🚧 Feedback
logsellram
ACTIONnew_bytes