Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gas v3 test #342

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gas v3 test #342

wants to merge 2 commits into from

Conversation

taokayan
Copy link
Contributor

Resolves #247

@taokayan taokayan requested a review from elmato December 20, 2024 10:17
@elmato
Copy link
Contributor

elmato commented Jan 7, 2025

If we use the same silkworm version on both (contract and node) the issue of having different balances goes away.
You can try elmato/discount-factor-and-refund or wait to be merged into master.

Then the issue that will arise is:

Traceback (most recent call last):
  File "/home/matu/dev/eos-evm-node/tests/nodeos_eos_evm_test.py", line 1333, in <module>
    assert(bal1 == bal2 + 1000000000000000000 + gasP * 21000)
AssertionError
2025-01-07T01:08:05.228310 Shutting down wallet manager process 49536

That I think is related to not taking into account the scaling of gas parameters.
You can look into how we are scaling them here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gas fee algorithm v3 integration tests
2 participants