Fix issues when LIB recorded from previous shutdown is at the edge of a gap #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmato
reviewed
May 6, 2024
src/engine_plugin.cpp
Outdated
| auto res = silkworm::db::read_canonical_header(txn, start_height); | ||
| if(!res) return {}; | ||
|
|
||
| for (int i = 0; i < 32; ++i) { |
There was a problem hiding this comment.
You can use !is_zero(res->prev_randao)
elmato
reviewed
May 6, 2024
| // the search process simple. | ||
| SILK_INFO << "Search for block containing a valid eos id. Start from:" << "#" << start_height; | ||
| silkworm::db::ROTxn txn(db_env); | ||
| do { |
There was a problem hiding this comment.
why not just use while(start_height>0) and decrement start_height inside the while body?
elmato
reviewed
May 6, 2024
| while(--start_height > 0); | ||
| return {}; | ||
| } | ||
|
|
There was a problem hiding this comment.
// Alternative implementation
std::optional<silkworm::BlockHeader> res;
while(start_height>0) {
res = silkworm::db::read_canonical_header(txn, start_height);
if(res && !is_zero(res->prev_randao)) {
break;
}
--start_height;
}
return res;There was a problem hiding this comment.
Refactor to do while again to handle the genesis case properly.
elmato
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #209