route websocket proxy traffics to different destinations #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmato
reviewed
Nov 20, 2023
There was a problem hiding this comment.
@taokayan looks like this PR is forking from a commit that is not including
elmato
reviewed
Nov 22, 2023
Comment on lines
133
to
141
| if( found_next_block == true ) { | ||
| while(this.reversible_blocks.length > 1024) { // protection of memory grow in case leap rpc not working | ||
| this.remove_front_block(); | ||
| } | ||
|
|
||
| if( found_next_block == true && this.reversible_blocks.length > 180 + 30) { // reduce frequency of calling get_evm_lib | ||
| const evm_lib = await this.get_evm_lib(); | ||
| while(this.reversible_blocks.length > 0 && this.reversible_blocks.peek().number < evm_lib) { | ||
| // keep at least 180 blocks in case evm-node is out of sync with leap | ||
| while(this.reversible_blocks.length > 180 && this.reversible_blocks.peek().number < evm_lib) { | ||
| this.remove_front_block(); |
There was a problem hiding this comment.
In case we are on a minority fork, we will be having different behaviors from the client perspective based on how long the fork takes to solve (since we will be removing reversible blocks from our queue)
Are we ok with this?
elmato
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #91
add web3_rpc_test_endpoint in config
add miner_rpc_endpoint in config
add whitelist_methods in config
always group all requests in a batch to send to either rpc endpoint or rpc test endpoint.
reduce frequency of get eos lib
add minmum (180) size in this.reversible_blocks as protection in case of evm-rpc is out of sync with leap endpoint