-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for storage and overhead price #750
Conversation
…ad_price and storage_price
…when generating contract abi
include/evm_runtime/tables.hpp
Outdated
}; | ||
} | ||
}; | ||
VALUE_PROMOTER(uint64_t); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
typedef uint64_t evm_version_type;
VALUE_PROMOTER(evm_version_type);
to reduce potential ambiguity.
include/evm_runtime/tables.hpp
Outdated
|
||
std::optional<pending> pending_version; | ||
uint64_t cached_version=0; | ||
struct gas_prices { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe rename to gas_prices_type to make it consistent with consensus_parameter_data_type
Also, consider change the name "gas_prices" everywhere to avoid confusion with gas_price (no s)
}; | ||
|
||
using evmtx_type = std::variant<evmtx_v0>; | ||
struct evmtx_v1 : evmtx_base { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we still keep the base price in evmtx_v3 so that it would be possible to implement the option to still use old model with high eos evm version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but two issue:
1 will gas_price and gas_prices cause confusion?
2 when we upgrade from v2 to v3, we stop using gas_price_queue. seems there missing some mechanism to clear the value stored (if any) n that table afterwards?
|
No description provided.