Be explicit that agent/container index is being requested #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/knuckle_cluster.rb
Outdated
| @@ -101,7 +101,7 @@ def select_agent(auto: false) | |||
|
|
|||
| output_agents | |||
|
|
|||
| puts "\nConnect to which agent?" | |||
| puts "\nConnect to which agent? (INDEX)" | |||
There was a problem hiding this comment.
How about something like the following?
Enter the INDEX number and press ENTER to connect:
My intention is to make the instruction more explicit and also get rid of the unnecessarily mentioning agents or containers.
There was a problem hiding this comment.
I like that version. I have updated to it. Commit pushed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not immediately clear to me that the index rather than name is being requested on the command line.
This code happily accepts a container name although the to_i turns it into a zero.
This PR modifies the command line prompt to explicitly state that an index should be entered.