Allow multiple oracle inputs #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameba23
approved these changes
Nov 12, 2024
| @@ -85,7 +85,7 @@ impl Runtime { | |||
| program: &[u8], | |||
| signature_request: &SignatureRequest, | |||
| config: Option<&[u8]>, | |||
| oracle_data: Option<&[u8]>, | |||
| oracle_data: Option<&[Vec<u8>]>, | |||
There was a problem hiding this comment.
Since all other arguments use &[u8] instead of Vec<u8> i guess maybe we should do that here. I'm not sure it makes any difference to the caller since its inside a reference to an array. So probably can leave it as it is.
pretty much and happy to walk you through it sometime but the input acts as a pointer to an oracle mapping in core, currently it only allowed one key heading, now it allows multiple |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows input for oracle data to be multiple inputs it pairs with entropyxyz/entropy-core#1153
I do not change the program version here as we do not have the infrastructure yet to support that (as well it really only makes sense for mainnet)