Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try both 'exec' and 'exec_' methods on QCoreApplication. #488

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Dec 7, 2021

This PR adds a compatibility fix for Qt6 support. Unfortunately there doesn't seem to be any reasonable way to avoid checking for both exec and exec_ for the near future: PyQt6 only has exec, while PySide2 only has exec_. PySide6 and PyQt5 support both.

No tests because:

  • support for Qt6 isn't yet in Pyface master support for Qt6 isn't yet in a Pyface release
  • this code is effectively part of the test machinery anyway - it's not currently used by Traits Futures clients

Once Pyface has released support for Qt6, we should add GitHub Actions workflows for testing on the various flavours of Qt versions and wrappers. I'll open a separate issue for that.

@mdickinson
Copy link
Member Author

I'll open a separate issue for that.

#489

Copy link

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - this is testing code by the look of things, so I assume that performance of testing for exception vs. getattr is not a concern; similarly with not trying to cache the result.

@mdickinson mdickinson merged commit 096a978 into main Dec 16, 2021
@mdickinson mdickinson deleted the fix/qt6-compatibility branch December 16, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants