Try both 'exec' and 'exec_' methods on QCoreApplication. #488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a compatibility fix for Qt6 support. Unfortunately there doesn't seem to be any reasonable way to avoid checking for both
exec
andexec_
for the near future: PyQt6 only hasexec
, while PySide2 only hasexec_
. PySide6 and PyQt5 support both.No tests because:
support for Qt6 isn't yet in Pyface mastersupport for Qt6 isn't yet in a Pyface releaseOnce Pyface has released support for Qt6, we should add GitHub Actions workflows for testing on the various flavours of Qt versions and wrappers. I'll open a separate issue for that.