Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for determining the language of a font #763

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Add support for determining the language of a font #763

merged 2 commits into from
Mar 29, 2021

Conversation

jwiggins
Copy link
Member

First step towards #762

rahulporuri
rahulporuri approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of minor comments

@jwiggins jwiggins merged commit edfc726 into master Mar 29, 2021
@jwiggins
Copy link
Member Author

Thanks for the feedback

@jwiggins jwiggins deleted the feature/font-languages branch March 29, 2021 15:24
@jwiggins jwiggins mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwiggins @rahulporuri