Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #37 - KeyEvent on Mac OS X #38

Closed
wants to merge 3 commits into from
Closed

Fix issue #37 - KeyEvent on Mac OS X #38

wants to merge 3 commits into from

Conversation

pberkes
Copy link
Contributor

@pberkes pberkes commented Oct 24, 2011

Issues with KeyEvent on Mac OS X issue #37

@corranwebster
Copy link
Contributor

This seems reasonable, although I'm not entirely sure about the addition of the 'Meta' key to Enable. If you are going to add 'Meta' you need to ensure that it is supported in all the backends (in particular, we do use the VTK back end in production code).

Also, have you validated that these changes don't lead to unexpected behaviour with the standard Chaco tools?

@pberkes
Copy link
Contributor Author

pberkes commented Nov 1, 2011

IMHO, being able to detect "meta" is important so that Mac users may use key combinations that are common on Mac. An alternative would be to map Meta to Ctrl always.

I can look into supporting 'meta' in other backends. Which of them are actually used? E.g. 'savage' seems to extinct.

I did not see see any unexpected change in standard chaco tools so far. Do you have any one in particular in mind?

@pberkes
Copy link
Contributor Author

pberkes commented Nov 24, 2011

vtkRenderWindowInteractor does not define a GetMetaKey method. The natural thing to do seems to always set meta_down to False in that case. It cannot break any code, since it could not be used before.
(Ref: http://www.vtk.org/doc/release/5.0/html/a01972.html)

@itziakos
Copy link
Member

@pberkes and @corranwebster, is there an update on this PR? Should it be merged?

@pberkes
Copy link
Contributor Author

pberkes commented Sep 23, 2013

@itziakos From what I remembered, the consensus was that these changes should be done for all the enable backends. I still think that we should be able to distinguish between Meta and Ctrl, especially on Mac, but this specific PR can be closed as far as I'm concerned.

@jwiggins
Copy link
Member

Closing

@jwiggins jwiggins closed this Dec 11, 2013
@corranwebster corranwebster deleted the fix_ctrl_cmd branch August 20, 2015 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants