Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 panel core #74

Merged
merged 3 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/Panel/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

# First stage

ARG BASE_IMAGE=quay.io/enthought/edm-centos-7:3.4.0
ARG BASE_IMAGE=quay.io/enthought/edm-centos-7:latest

FROM $BASE_IMAGE as stage_one

Expand Down
10 changes: 3 additions & 7 deletions Core/Panel/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ collecting environment variables set by Edge when the container is launched.

When developing locally, it's also convenient to have an EdgeSession. You
can get the "ci" module to inject the appropriate environment variables, so
that your ``EdgeSession()`` call will work with ``python -m ci run`` and
``python -m ci preflight``.
that your ``EdgeSession()`` call will work with ``python -m ci run``.

To do so, follow this procedure:

Expand All @@ -85,8 +84,8 @@ To do so, follow this procedure:
``"https://edge.enthought.com/services/api"``.
* Define EDGE_API_ORG in that file. This is the "short name" displayed in
the URL bar when you log into an organization, for example, ``"default"``.
* Define EDGE_API_TOKEN. You can get one of these by going to the
``/hub/token`` endpoint on the Edge server.
* Define EDGE_API_TOKEN. You can get one of these from the ``My Profile``page
in the Edge UI.

Be sure *not* to check the "dev_settings.json" file into source control, as it
contains your API token.
Expand All @@ -105,9 +104,6 @@ the prefix from requests, handling the OAuth2 login flow, pinging JupyterHub
for container activity, and more. But, there are a few guidelines you will
need to follow in your own Dockerfile.

* Don't change the user to anything other than ``app`` (for example, by the
Dockerfile ``USER`` command). If you need to run ``yum`` for some reason,
use ``sudo``.
* Your app should bind to ``127.0.0.1``, *not* ``0.0.0.0``, and it should serve
on port 9000. The Edge machinery will respond to requests on port 8888 and
forward them to your app.
Expand Down
2 changes: 1 addition & 1 deletion Core/Streamlit/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

# First stage

ARG BASE_IMAGE=quay.io/enthought/edm-centos-7:3.4.0
ARG BASE_IMAGE=quay.io/enthought/edm-centos-7:latest

FROM $BASE_IMAGE as stage_one

Expand Down
10 changes: 3 additions & 7 deletions Core/Streamlit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ collecting environment variables set by Edge when the container is launched.

When developing locally, it's also convenient to have an EdgeSession. You
can get the "ci" module to inject the appropriate environment variables, so
that your ``EdgeSession()`` call will work with ``python -m ci run`` and
``python -m ci preflight``.
that your ``EdgeSession()`` call will work with ``python -m ci run``.

To do so, follow this procedure:

Expand All @@ -86,8 +85,8 @@ To do so, follow this procedure:
``"https://edge.enthought.com/services/api"``.
* Define EDGE_API_ORG in that file. This is the "short name" displayed in
the URL bar when you log into an organization, for example, ``"default"``.
* Define EDGE_API_TOKEN. You can get one of these by going to the
``/hub/token`` endpoint on the Edge server.
* Define EDGE_API_TOKEN. You can get one of these from the ``My Profile``page
in the Edge UI.

Be sure *not* to check the "dev_settings.json" file into source control, as it
contains your API token.
Expand All @@ -106,9 +105,6 @@ the prefix from requests, handling the OAuth2 login flow, pinging JupyterHub
for container activity, and more. But, there are a few guidelines you will
need to follow in your own Dockerfile.

* Don't change the user to anything other than ``app`` (for example, by the
Dockerfile ``USER`` command). If you need to run ``yum`` for some reason,
use ``sudo``.
* Your app should bind to ``127.0.0.1``, *not* ``0.0.0.0``, and it should serve
on port 9000. The Edge machinery will respond to requests on port 8888 and
forward them to your app.
Expand Down
Loading